Support completable animations in Compose tests #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headsvk
force-pushed
the
feature/complete-animation
branch
from
44a573d
to
e9db247
Compare
gpeal
reviewed
Apr 4, 2022
| return if (iterations == LottieConstants.IterateForever) { | ||
| // We use withInfiniteAnimationFrameNanos because it allows tests to add a CoroutineContext | ||
| // element that will cancel infinite transitions instead of preventing composition from ever going idle. | ||
| withInfiniteAnimationFrameNanos { frameNanos: Long -> |
There was a problem hiding this comment.
Suggested change
| withInfiniteAnimationFrameNanos { frameNanos: Long -> | |
| withInfiniteAnimationFrameNanos { frameNanos -> |
There was a problem hiding this comment.
right, fixed this copy paste
| onFrame(iterations, frameNanos) | ||
| } | ||
| } else { | ||
| withFrameNanos { frameNanos: Long -> |
There was a problem hiding this comment.
Suggested change
| withFrameNanos { frameNanos: Long -> | |
| withFrameNanos { frameNanos -> |
There was a problem hiding this comment.
right, fixed this copy paste
headsvk
force-pushed
the
feature/complete-animation
branch
from
e9db247
to
9ef8491
Compare
gpeal
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #1987 to always use
withInfiniteAnimationFrameNanosprevents non-infinite animations from completing in Compose tests.I added a simple check to use
withFrameNanosorwithInfiniteAnimationFrameNanosbased on the number of iterations. This fixes tests that wait for animations to complete, see sampleWalkthroughAnimationTest. AndInfiniteAnimationTeststill passes.Let me know if I'm missing some other use case.